CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

moduleHandler: configureModule contains nasty code but still works #120

Closed gundas closed 7 years ago

gundas commented 7 years ago

The configureModule function uses schelling contract to call configure method on token and provider contracts - https://github.com/CORIONplatform/solidity/blob/master/moduleHandler.sol#L427

It looks nasty, but it works as long as the token and provider contracts define the configure or a fallback function.

I guess a nicer way would be to add default configure function to module and to abstractModule.

iFA88 commented 7 years ago

Have soon done in https://github.com/CORIONplatform/solidity/blob/iFA-FIX . Modules have now standard configureModule function.