Closed gundas closed 7 years ago
Hi!
I code in remix (browser solidity) if I have the providerDB
in a separate file, I can not use highlighting what I use very common. Sadly the search (CTRL+F) is really buggy. BUT yes, when I'm done its nice to have in an separated file.
In the provider
contract I have created internal functions for each providerDB
as you see. This is important to 'catch' the errors and I don't need check the success
some function who I call DB function. I think, I don't have any function in the provider
what I don't use, but if you find one please let me know :)
The success
variable is very important from an "third party" contract.
Hello,
I understand this is a matter of preference.
I think the readability of the code would improve if:
providerDB
would be separated into another fileproviderDB
function in theprovider
contract. It (mostly) does not do anything else besides calling the 'providerDB'. I think it makes the code much less readible without adding anything useful (providerDB
could be re-coded to fail if the function does not succeed instead of always returningsuccess=true
).