search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

setProviderDetails(...) admin has to always reset admin to 0x00 #145

Closed gundas closed 7 years ago

gundas commented 7 years ago

https://github.com/CORIONplatform/solidity/blob/provider-recode/provider.sol#L954-L956

if admin user calls the setProviderDetails(...) function, he has to supply argument admin=0x00. The intention is that admin cannot change admin of the provider. However, as a result of such call, the admin of the provider will be set to 0x00. So the admin user will kind of "lock himself out" if he ever tries to update the provider details.

iFA88 commented 7 years ago

Nice catch! Have changed the code, please review it.