search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

It is possible to create provider for rent without an admin #154

Closed gundas closed 7 years ago

gundas commented 7 years ago

If I create a new provider IsForRent=true and admin=msg.sender, the check will pass:

        require( ( ! isForRent ) || ( isForRent && admin != 0x00) );

but the admin will be set to 0x00 later in internal _openProvider(...) function.

iFA88 commented 7 years ago

You have right, if anyone opens an provider for isForRent we need an admin for that!

iFA88 commented 7 years ago

Please, in the future check only the rc branch, because this branch would be deployed for next. https://github.com/CORIONplatform/solidity/tree/rc

Thank you!