search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

Hidden logic. Variable names do not display their use. Readability of the code. #72

Closed Dexaran closed 7 years ago

Dexaran commented 7 years ago

https://github.com/CORIONplatform/solidity/blob/master/schelling.sol#L210

Variable names should make their use understandable to the programmer who will read this code. Please, name variables to make logic of the contract explicit. Keep the code readable.

This will reduce the possibility of an error when the auditor or bug hunter has missed the error due to terrible code readability.

iFA88 commented 7 years ago

Schelling will be recoded with the "new" style!