exchange.sol has its own variant of the owned.sol contract, ico.sol contains a third implementation of this check

CORIONplatform / solidity

GNU General Public License v3.0

12 stars 9 forks source link

exchange.sol has its own variant of the owned.sol contract, ico.sol contains a third implementation of this check #79

Closed pyskell closed 7 years ago

pyskell commented 7 years ago

Should this be the case? Are there supposed to be two possible owners, one for the exchange, and one for the tokenDB?

Even in such a case couldn't this be abstracted to use the same contract via OpenZeppelin's Ownable contract?

Related to this the code in both contracts are not currently equivalent.

pyskell commented 7 years ago

Related to this, ico.sol has require(msg.sender == owner); instead of either of the other two options I mentioned previously.

iFA88 commented 7 years ago

Exchange is under development! This is an "third party" contract which offers COR/ETC trading for anyone. For ICO owner would be temporarily the foundation.