search

CORIONplatform / solidity

GNU General Public License v3.0
12 stars 9 forks source link

moduleHandler: callReplaceCallback might replace wrong module #91

Closed gundas closed 7 years ago

gundas commented 7 years ago

https://github.com/CORIONplatform/solidity/blob/master/moduleHandler.sol#L175-L176

if module is not found by the name (_found is not checked), then unrelated module with '_id=0' will be replaced with a new one.

iFA88 commented 7 years ago

https://github.com/CORIONplatform/solidity/commit/14b5dbaf281997c4ac002027d5ff5b2a8027eb1e

gundas commented 7 years ago

It should check the _found not the _id - now the module with _id=0 cannot be replaced.

iFA88 commented 7 years ago

https://github.com/CORIONplatform/solidity/pull/99