COS301-SE-2024 / ClassConnect

ClassConnect is an innovative educational platform that blends the traditional learning hub with a 3D learning environment.
https://www.class-connect.online/
11 stars 1 forks source link

Feature/live session #58

Closed Ashley-Kapaso closed 2 weeks ago

Ashley-Kapaso commented 2 weeks ago

Pull Request

Description:

Implemented live session functionality

Related Issues:

[Reference any related issues or documents.]

Type of Change:

Checklist:

Reviewers:

Testing Instructions:

[Provide clear and concise instructions on how to test your changes.]

Screenshots (if applicable):

[Add screenshots to help reviewers understand the changes visually.]

Additional Notes:

[Any additional information that may be helpful for reviewers.]

gitguardian[bot] commented 2 weeks ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11682765](https://dashboard.gitguardian.com/workspace/301252/incidents/11682765?occurrence=146047646) | Triggered | Generic High Entropy Secret | bf28c5153e783f77d996aa2b330a4d3dd6ab9ca8 | src/client/src/lib/stores/store.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/bf28c5153e783f77d996aa2b330a4d3dd6ab9ca8#diff-6c9e8f78cc1265b765cf28759cbb578b98b3dac64b766e086e7fd861b4aa02c1R30) | | [11682765](https://dashboard.gitguardian.com/workspace/301252/incidents/11682765?occurrence=146337893) | Triggered | Generic High Entropy Secret | f2185d0eb8dcf32570ae99abebde2557a3f6c424 | src/client/src/lib/stores/store.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/f2185d0eb8dcf32570ae99abebde2557a3f6c424#diff-6c9e8f78cc1265b765cf28759cbb578b98b3dac64b766e086e7fd861b4aa02c1L30) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.63%. Comparing base (d37a263) to head (f2185d0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #58 +/- ## =========================================== - Coverage 60.75% 60.63% -0.13% =========================================== Files 29 29 Lines 316 315 -1 Branches 14 14 =========================================== - Hits 192 191 -1 - Misses 122 124 +2 + Partials 2 0 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.