COS301-SE-2024 / ClassConnect

ClassConnect is an innovative educational platform that blends the traditional learning hub with a 3D learning environment.
https://www.class-connect.online/
11 stars 1 forks source link

Update/auth #95

Closed Ashley-Kapaso closed 2 days ago

Ashley-Kapaso commented 5 days ago

Pull Request

Description:

Type of Change:

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.96%. Comparing base (1804f3f) to head (150316c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #95 +/- ## ======================================== Coverage 66.96% 66.96% ======================================== Files 41 41 Lines 451 451 Branches 14 14 ======================================== Hits 302 302 Misses 147 147 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gitguardian[bot] commented 4 days ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663460) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR125) | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663461) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR70) | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663462) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR71) | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663463) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR105) | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663464) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR124) | | [12333993](https://dashboard.gitguardian.com/workspace/301252/incidents/12333993?occurrence=151663465) | Triggered | Generic Password | 40cd241821cc58a8ca8c584798ca24f2055e87fb | src/client/src/routes/(auth)/signup/page.server.test.ts | [View secret](https://github.com/COS301-SE-2024/ClassConnect/commit/40cd241821cc58a8ca8c584798ca24f2055e87fb#diff-bdf8fa97e1c47caed49717c07283af834f7ba40230d0eb89708f9d047b79b08eR106) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.