search

COS301-SE-2024 / Events-System

Our team brings you an innovative team collaboration site powered by angular, structured and managed by NX
3 stars 1 forks source link

Develop #177

Closed RXA8 closed 1 month ago

RXA8 commented 1 month ago

Pull Request

Description:

[Provide a concise summary of your changes and why they are necessary.]

Related Issues:

[Reference any related issues or documents.]

Type of Change:

Checklist:

Reviewers:

Testing Instructions:

[Provide clear and concise instructions on how to test your changes.]

Screenshots (if applicable):

[Add screenshots to help reviewers understand the changes visually.]

Additional Notes:

[Any additional information that may be helpful for reviewers.]

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 16 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13467434](https://dashboard.gitguardian.com/workspace/301252/incidents/13467434?occurrence=163340915) | Triggered | Google API Key | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049L7) | | [13467434](https://dashboard.gitguardian.com/workspace/301252/incidents/13467434?occurrence=163340917) | Triggered | Google API Key | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049R7) | | [13467434](https://dashboard.gitguardian.com/workspace/301252/incidents/13467434?occurrence=163340919) | Triggered | Google API Key | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aL7) | | [13467434](https://dashboard.gitguardian.com/workspace/301252/incidents/13467434?occurrence=163340923) | Triggered | Google API Key | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aR7) | | [13467435](https://dashboard.gitguardian.com/workspace/301252/incidents/13467435?occurrence=163340918) | Triggered | Contentful Content Management API Key | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aL2) | | [13467435](https://dashboard.gitguardian.com/workspace/301252/incidents/13467435?occurrence=163340924) | Triggered | Contentful Content Management API Key | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aR2) | | [13467435](https://dashboard.gitguardian.com/workspace/301252/incidents/13467435?occurrence=163340925) | Triggered | Contentful Content Management API Key | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049L2) | | [13467435](https://dashboard.gitguardian.com/workspace/301252/incidents/13467435?occurrence=163340926) | Triggered | Contentful Content Management API Key | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049R2) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340911) | Triggered | Google OAuth2 Keys | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049R4) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340912) | Triggered | Google OAuth2 Keys | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049R6) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340913) | Triggered | Google OAuth2 Keys | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aL6) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340914) | Triggered | Google OAuth2 Keys | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aR4) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340916) | Triggered | Google OAuth2 Keys | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049L4) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340920) | Triggered | Google OAuth2 Keys | b84b0b407cd929f08f75d1cd0e57cb5223a45546 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/b84b0b407cd929f08f75d1cd0e57cb5223a45546#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aR6) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340921) | Triggered | Google OAuth2 Keys | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-d897f7d114ca657c43905bff9a6ee17e53e2d1ccc172b7c258a54183653a691aL4) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=163340922) | Triggered | Google OAuth2 Keys | f0aeeed449f659abc83fe4e3698a026c2594d1e6 | src/environments/environment.development.ts | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/f0aeeed449f659abc83fe4e3698a026c2594d1e6#diff-a8781811a71ccc5e6e8919aa7054cf3a9c66d8624b4687cb9029aa12a5b93049L6) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 41.27%. Comparing base (eacf11d) to head (99a953f). Report is 15 commits behind head on feat/analytics.

Files with missing lines Patch % Lines
src/app/authguard.guard.ts 10.00% 9 Missing :warning:
src/app/auth.service.ts 0.00% 4 Missing :warning:
src/app/refresh.service.ts 42.85% 4 Missing :warning:
src/app/app.routes.ts 0.00% 1 Missing :warning:
src/app/websocket.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/analytics #177 +/- ## ================================================== - Coverage 43.45% 41.27% -2.19% ================================================== Files 72 75 +3 Lines 214 235 +21 Branches 8 9 +1 ================================================== + Hits 93 97 +4 - Misses 121 138 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.