search

COS301-SE-2024 / Events-System

Our team brings you an innovative team collaboration site powered by angular, structured and managed by NX
3 stars 1 forks source link

Feat/wow factor #189

Closed Mathenda closed 1 week ago

Mathenda commented 1 week ago

Pull Request

Description:

[Provide a concise summary of your changes and why they are necessary.]

Related Issues:

[Reference any related issues or documents.]

Type of Change:

Checklist:

Reviewers:

Testing Instructions:

[Provide clear and concise instructions on how to test your changes.]

Screenshots (if applicable):

[Add screenshots to help reviewers understand the changes visually.]

Additional Notes:

[Any additional information that may be helpful for reviewers.]

gitguardian[bot] commented 1 week ago

⚠️ GitGuardian has uncovered 18 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13861045](https://dashboard.gitguardian.com/workspace/301252/incidents/13861045?occurrence=165985390) | Triggered | Eventbrite OAuth2 Token | 73b649bb5b74e4c1922070d22343dd866048c90b | Interface/test.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-f9d03f53dfda0d2420d9671c9697a46ce1347c07fd73db6905f4d06f1ac44a2fR4) | | [13861046](https://dashboard.gitguardian.com/workspace/301252/incidents/13861046?occurrence=165985387) | Triggered | Generic High Entropy Secret | 73b649bb5b74e4c1922070d22343dd866048c90b | Interface/ai-service.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-d11dab27010918223ae6b88a4b9906daba723ff98f504dad15a07f01e4484451R18) | | [13861047](https://dashboard.gitguardian.com/workspace/301252/incidents/13861047?occurrence=165985385) | Triggered | Generic High Entropy Secret | 73b649bb5b74e4c1922070d22343dd866048c90b | .npmrc | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-e813096d69c49812e40e00be9ac8fa14d77f0ec1f97ab4c45cb096b3bedd35deR2) | | [13861048](https://dashboard.gitguardian.com/workspace/301252/incidents/13861048?occurrence=165985382) | Triggered | Generic Database Assignment | 73b649bb5b74e4c1922070d22343dd866048c90b | Interface/ai-service.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-d11dab27010918223ae6b88a4b9906daba723ff98f504dad15a07f01e4484451R25) | | [13861048](https://dashboard.gitguardian.com/workspace/301252/incidents/13861048?occurrence=165985392) | Triggered | Generic Database Assignment | 73b649bb5b74e4c1922070d22343dd866048c90b | Interface/recommend.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-ff4e2a23c2a150f1dbff1cb3c2026eb21236b6fc9c04da955b40b90a0e7548b5R15) | | [11407584](https://dashboard.gitguardian.com/workspace/301252/incidents/11407584?occurrence=165985384) | Triggered | PostgreSQL Credentials | 73b649bb5b74e4c1922070d22343dd866048c90b | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25R5) | | [13861049](https://dashboard.gitguardian.com/workspace/301252/incidents/13861049?occurrence=165985388) | Triggered | Generic Password | 73b649bb5b74e4c1922070d22343dd866048c90b | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25R37) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=165985383) | Triggered | Google OAuth2 Keys | 73b649bb5b74e4c1922070d22343dd866048c90b | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25R7) | | [13861050](https://dashboard.gitguardian.com/workspace/301252/incidents/13861050?occurrence=165985391) | Triggered | Generic Password | 73b649bb5b74e4c1922070d22343dd866048c90b | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/73b649bb5b74e4c1922070d22343dd866048c90b#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25R9) | | [11407584](https://dashboard.gitguardian.com/workspace/301252/incidents/11407584?occurrence=166061956) | Triggered | PostgreSQL Credentials | 173b7098960398153c6a790ad2a923ea92eb9892 | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/173b7098960398153c6a790ad2a923ea92eb9892#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25L5) | | [13467436](https://dashboard.gitguardian.com/workspace/301252/incidents/13467436?occurrence=166061958) | Triggered | Google OAuth2 Keys | 173b7098960398153c6a790ad2a923ea92eb9892 | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/173b7098960398153c6a790ad2a923ea92eb9892#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25L7) | | [13861045](https://dashboard.gitguardian.com/workspace/301252/incidents/13861045?occurrence=166000383) | Triggered | Eventbrite OAuth2 Token | 571ee49d4303284cc07577ab04276d0c6f8303fe | Interface/test.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/571ee49d4303284cc07577ab04276d0c6f8303fe#diff-f9d03f53dfda0d2420d9671c9697a46ce1347c07fd73db6905f4d06f1ac44a2fL4) | | [13861046](https://dashboard.gitguardian.com/workspace/301252/incidents/13861046?occurrence=165985389) | Triggered | Generic High Entropy Secret | 6c1d141e46a144b541391d9c746cb464f86c582e | Interface/ai-service.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/6c1d141e46a144b541391d9c746cb464f86c582e#diff-d11dab27010918223ae6b88a4b9906daba723ff98f504dad15a07f01e4484451L18) | | [13861047](https://dashboard.gitguardian.com/workspace/301252/incidents/13861047?occurrence=166061957) | Triggered | Generic High Entropy Secret | 173b7098960398153c6a790ad2a923ea92eb9892 | .npmrc | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/173b7098960398153c6a790ad2a923ea92eb9892#diff-e813096d69c49812e40e00be9ac8fa14d77f0ec1f97ab4c45cb096b3bedd35deL2) | | [13861047](https://dashboard.gitguardian.com/workspace/301252/incidents/13861047?occurrence=166061965) | Triggered | Generic High Entropy Secret | ff88bc9d9ded216fac466d1944fe5efc6011bd8d | .npmrc | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/ff88bc9d9ded216fac466d1944fe5efc6011bd8d#diff-e813096d69c49812e40e00be9ac8fa14d77f0ec1f97ab4c45cb096b3bedd35deR2) | | [13861048](https://dashboard.gitguardian.com/workspace/301252/incidents/13861048?occurrence=166000384) | Triggered | Generic Database Assignment | 571ee49d4303284cc07577ab04276d0c6f8303fe | Interface/recommend.py | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/571ee49d4303284cc07577ab04276d0c6f8303fe#diff-ff4e2a23c2a150f1dbff1cb3c2026eb21236b6fc9c04da955b40b90a0e7548b5L15) | | [13861049](https://dashboard.gitguardian.com/workspace/301252/incidents/13861049?occurrence=166061959) | Triggered | Generic Password | 173b7098960398153c6a790ad2a923ea92eb9892 | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/173b7098960398153c6a790ad2a923ea92eb9892#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25L37) | | [13861050](https://dashboard.gitguardian.com/workspace/301252/incidents/13861050?occurrence=166061960) | Triggered | Generic Password | 173b7098960398153c6a790ad2a923ea92eb9892 | Backend/src/main/resources/application.properties | [View secret](https://github.com/COS301-SE-2024/Events-System/commit/173b7098960398153c6a790ad2a923ea92eb9892#diff-620b0ae7dd60ab859ff2019f38f1353b9ff311a228b4a9dd06215f99dec88c25L9) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/eventbrite_oauth_token#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

cloudflare-workers-and-pages[bot] commented 1 week ago

Deploying events-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff88bc9
Status: ✅  Deploy successful!
Preview URL: https://72f34cea.events-system.pages.dev
Branch Preview URL: https://feat-wow-factor.events-system.pages.dev

View logs

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.35%. Comparing base (0aa29a5) to head (ff88bc9). Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
src/app/google-maps-loader.service.ts 35.00% 13 Missing :warning:
src/app/app.routes.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #189 +/- ## =========================================== + Coverage 40.23% 40.35% +0.11% =========================================== Files 76 82 +6 Lines 251 280 +29 Branches 9 11 +2 =========================================== + Hits 101 113 +12 - Misses 150 167 +17 ``` | [Flag](https://app.codecov.io/gh/COS301-SE-2024/Events-System/pull/189/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COS301-SE-2024) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/COS301-SE-2024/Events-System/pull/189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COS301-SE-2024) | `40.35% <44.82%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COS301-SE-2024#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.