COS301-SE-2024 / WorkWise-Central

WorkWise Central is a service-management tool designed for service-based industries. It is engineered to streamline operations, maximize resource efficiency, and elevate customer experiences.
https://tuksui.sharpsoftwaresolutions.net/
7 stars 2 forks source link

Feature/integrate client portal feedback invoice payment gateway #660

Closed JessBloem closed 2 weeks ago

JessBloem commented 3 weeks ago

Pull Request

Description: Integrated the client portal, feeback and invoice page

Related Issues:

[Reference any related issues or documents.]

Type of Change:

Checklist:

Screenshots (if applicable):

[Add screenshots to help reviewers understand the changes visually.]

Reviewers:

Additional Notes:

[Any additional information that may be helpful for reviewers.]

gitguardian[bot] commented 3 weeks ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13718691](https://dashboard.gitguardian.com/workspace/301252/incidents/13718691?occurrence=164944088) | Triggered | Generic Password | 01c45b41c0d995d1dd8bfde5c6ba2bced4e27793 | src/frontend/src/components/home/clients/client_portal/PaymentPortal.vue | [View secret](https://github.com/COS301-SE-2024/WorkWise-Central/commit/01c45b41c0d995d1dd8bfde5c6ba2bced4e27793#diff-c0fa560c2d964cd13a93b3c05acfbcb7050bdd94c747a70a1d26ceda38b4c685R83) | | [13718691](https://dashboard.gitguardian.com/workspace/301252/incidents/13718691?occurrence=165044971) | Triggered | Generic Password | 5dc11aa75d3473d49a2ecc0752a3c6aba2aa1c31 | src/frontend/src/components/home/clients/client_portal/PaymentPortal.vue | [View secret](https://github.com/COS301-SE-2024/WorkWise-Central/commit/5dc11aa75d3473d49a2ecc0752a3c6aba2aa1c31#diff-c0fa560c2d964cd13a93b3c05acfbcb7050bdd94c747a70a1d26ceda38b4c685L83) | | [13718691](https://dashboard.gitguardian.com/workspace/301252/incidents/13718691?occurrence=165876491) | Triggered | Generic Password | 68d242ab47b22677775c29089a9d3bb4ee1ab166 | src/frontend/src/components/home/clients/client_portal/PaymentPortal.vue | [View secret](https://github.com/COS301-SE-2024/WorkWise-Central/commit/68d242ab47b22677775c29089a9d3bb4ee1ab166#diff-c0fa560c2d964cd13a93b3c05acfbcb7050bdd94c747a70a1d26ceda38b4c685L85) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.58%. Comparing base (5defefd) to head (ab531e8). Report is 55 commits behind head on develop.

Files with missing lines Patch % Lines
...api-gateway/src/invoices/dto/create-invoice.dto.ts 0.00% 3 Missing :warning:
...api-gateway/src/invoices/dto/update-invoice.dto.ts 0.00% 1 Missing :warning:
...pi-gateway/src/invoices/entities/invoice.entity.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #660 +/- ## ======================================== Coverage 64.58% 64.58% ======================================== Files 105 105 Lines 2239 2245 +6 Branches 68 68 ======================================== + Hits 1446 1450 +4 - Misses 747 749 +2 Partials 46 46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hamza-Mokiwa commented 3 weeks ago

Please remove the hardcoded test credentials in your code, I have already skipped GitGuardian Security Checks