COS420-Fall24 / Team-F

Team Firetruck's COS 420 working repository
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Video - Address Feedback #109

Open Noah-Moring opened 4 days ago

Noah-Moring commented 4 days ago

I think everyone should look at Greg's feedback for this even though Liam was the one that recorded it. It's important for everyone to be aware of. Additionally, read Greg's overall feedback from last deliverable. They really believe we should be focusing more on design and mockups to really build out some of these ideas before we continue with implementation.

10 points: Record a short 1-10 minute video showing the progress your team has made, walking through, for each feature, show the user story/use case briefly, then the mockup, then the automated tests, then the code, then the website in the browser, and say who contributed what to the development for each. This is meant to simulate the demo that happens with the Product Owner and stakeholders in an industry sprint review. It also mimics how you need to explain your code to others during a code review. If this video is missing, -10 Here is an example video from Deliverable 4 from Team D Fall 23. Starting 0min 34seconds is a good example for a single feature. Be sure to show the test code for each feature and briefly explain them, don’t just show that tests run. If you are missing any of "show the user story/use case briefly, then the mockup, then the automated tests, then the code, then the website in the browser, and say who contributed what to the development for each" -5 for each thing missing 8.5/10 Very good overall, really great for a first pass https://youtu.be/9yHB2wGNciY?t=279 This is a little out of order, e.g. the test, code, then mockup was shown, this is hard to follow since I don’t know what it should behave like before seeing tests and code Need to walk through the behavior a bit more eg at https://youtu.be/9yHB2wGNciY?t=308 analyzeTone isn’t shown and is the core of the implementation The side by side is great, it was unclear to me who was on which side at first, introducing the LHS as liam, RHS as the other person. Also I’d go with totally separate test users eg Liam and Liam 2.0 is confusing Cursor size is very small in the video, easy to increase that in accessibility settings before recording Use control or command clicking in VSCode to navigate quickly eg click on MockDiscord and it will jump to the definition Lol you all did a lot of work this deliverable so you ran out of time in the video, it’s fine to go over, ask me next time. I don’t know where your bot github is otherwise I’d look over the code more. Project is looking great to me! I think you all just need to focus on designing the interactions, creating mockups that show exactly how it would work with realistic user interactions so you can tell what kinds of outputs you’d like the tone detection to actually give to users so you can do prompt engineering for that, etc Write a short comment in each unit test file on the first test at least on the testing pattern e.g. the setup the command mocks which will be called, then await, then checking mocks were called, etc. In the future, don’t assign this video to one person, each person needs to do their part then someone stitches them. Just agree to follow the video format and QC it e.g. “user story/use case briefly, then the mockup, then the automated tests, then the code, then the website in the browser,”