COSC-499-W2023 / year-long-project-team-12

year-long-project-team-12 created by GitHub Classroom
0 stars 1 forks source link

Profile picture Change #261

Closed PhilipOkorie closed 7 months ago

PhilipOkorie commented 7 months ago

What is this change?

Why are you making this change?

Link to design document/Github issues:

What testing was conducted?

Does the change have unit test coverage

Abdulhameed23 commented 7 months ago

The profile image is being cutoff by the background image, perhaps try to overlay it.

Abdulhameed23 commented 7 months ago

@PhilipOkorie On line 89 - 92, I am not completely sure you can see it but there is a box there that was placed initially by @yemoski when the profile pic was a placeholder. You can either use that box or remove it. If you remove "border-radius: 50%" in the profile.scss file on line 20, you will see the box.

image

PhilipOkorie commented 7 months ago

@PhilipOkorie On line 89 - 92, I am not completely sure you can see it but there is a box there that was placed initially by @yemoski when the profile pic was a placeholder. You can either use that box or remove it. If you remove "border-radius: 50%" in the profile.scss file on line 20, you will see the box.

image

PhilipOkorie commented 7 months ago

Fixed the positioning

PhilipOkorie commented 7 months ago
Screenshot 2024-02-24 at 7 53 54 PM
PhilipOkorie commented 7 months ago

Also got rid of the box