search

COSC481W-2022Winter / capstone-hackmcx

capstone-hackmcx created by GitHub Classroom
0 stars 1 forks source link

feat: Add Migrations and Seed for Captions #64

Closed zxkevin closed 2 years ago

zxkevin commented 2 years ago

Added the migration for creation of captions table and added Caption seed data

60

3dxp commented 2 years ago

Nice work on this @zxkevin. Looks good to me. Should be good to merge after comments are addressed.

acampb65 commented 2 years ago

We probably want to add the notNullable() method to the username, first_name, and last_name columns of the users table during migration.

acampb65 commented 2 years ago

2022-03-09_1502.cjs should probably be renamed to something like 2022-03-09_1502_demo_captions.cjs

zxkevin commented 2 years ago

I left the name fields nullable for maybe the anonymous users in the future and just to give people the option to decide if or not they want to include their name. The username is notnullable by default due to it being the primary key.