Feature: Fetch weather based on current location

COSC481W-2024Winter / JARVIS

J.A.R.V.I.S

2 stars 3 forks source link

Feature: Fetch weather based on current location #65

Closed Luna-Jia closed 7 months ago

Luna-Jia commented 8 months ago

Update WeatherService to request location permission and handle denied cases
Modify the weather button to trigger location permission request
Display weather condition and temperature based on user's current location

issue #54

https://github.com/COSC481W-2024Winter/JARVIS/assets/73403516/7f0eb371-06f4-4971-8fc0-0a3430356605

ghost commented 7 months ago

problem in the test.

haohuazheng3 commented 7 months ago

Try to fix the test that Emily mentioned and then make new pull request

ghost commented 7 months ago

several comments there were numerous minor errors that I resolved with merge conflicts.

however the application is not requesting permissions, so it can't get my location. Therefore the most important feature is to make sure it properly requests permissions.

ghost commented 7 months ago

fixed this error, by looking at the code you put your new code under the news button, but it should have been under the weather code. This allows for actually getting the users current location properly. @haohuazheng3 has further requested that there be some method to stop speech. His method is if you click the button again, then it stops. You can see this under his news button code. Please reopen the request when you have integrated this change

haohuazheng3 commented 7 months ago

***Fetch the latest information from the main branch. Based on my _isSpeaking parameter and the solution in my News Summary(), resolve your part AI speaking bug. For example, clicking the first time will start reading, clicking again (second time) during the reading process will stop it, and clicking once more (third time) will restart the reading. You don't need to fix the bug where the reading continues even after exiting the software, as I have fixed that in home.dart. Also, Emily mentioned that she didn't see a permission request, which means that this feature seems to be directly obtaining the location without requesting permission from the user.

ghost commented 7 months ago

I already fixed the request, its just she put her new code under the news summary button instead of the weather button, everything is resolved except for the start/stop of sound.

ghost commented 7 months ago

looks good to me, stops and starts.