fix(dev): check input before creating project - Githubissues

COSCUP / COSCUP-Volunteer

The COSCUP volunteer platform is an online tool that allows interested individuals to register as volunteers for the conference, and a way for volunteers to communicate with each other and with the organizers. COSCUP 志工平台是一個可以讓有興趣的人登錄成為 COSCUP 的志工，同時也提供志工彼此溝通和與大會聯繫的方式。

https://volunteer.coscup.org/

GNU Affero General Public License v3.0

67 stars 34 forks source link

fix(dev): check input before creating project #100

Closed pan93412 closed 2 years ago

pan93412 commented 2 years ago

修正 /dev 建立專案時的 UX。詳見 “What is the current behavior?”

Pull request type

Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

(fix) create_project 若有未填寫完善的項目，目前按下 “Save”：
- 用戶端 (Web) 沒有反應。
- 伺服器端回傳 500 錯誤。
(refactor) dev.py 的 casename 有重複程式碼。

What is the new behavior?

用戶端加上 catch()，讓使用者知道發生錯誤。
伺服器端事先檢查每個欄位是否填妥，若未填妥改回傳 400（指示是使用者的問題）
dev.py 的 casename 往上抽，並改用 .get() 去掉 if 'field' in dict 的檢查部分。

SCR-20220713-ddp

Other information