COSCUP / COSCUP-Volunteer

The COSCUP volunteer platform is an online tool that allows interested individuals to register as volunteers for the conference, and a way for volunteers to communicate with each other and with the organizers. COSCUP 志工平台是一個可以讓有興趣的人登錄成為 COSCUP 的志工,同時也提供志工彼此溝通和與大會聯繫的方式。
https://volunteer.coscup.org/
GNU Affero General Public License v3.0
67 stars 34 forks source link

#113 filter expense by status #134

Closed ddio closed 1 year ago

ddio commented 1 year ago

Pull request type

Issue Number: #113

What is the new behavior?

  1. Implement #113
  2. Add /static directory, so to create shared vue component
    1. @toomore , please help to review this. I just verify this under local dev env.
  3. Now we support limited vue component feature!
    • As there's no webpack or vue-loader, plain JS file is used.
    • i.e. No <tpl> tag, please apply HTML in plain text.

Other information

  1. Default show 申請中 expense

    螢幕快照 2023-04-23 23-27-44

  2. Show 目前沒有<status label>的項目 when no expense item under this status

    螢幕快照 2023-04-23 23-27-42

toomore commented 1 year ago

@ddio 看起來除了 commits 沒有 sign-off 外,其他沒什麼問題!

ddio commented 1 year ago

@toomore 感謝回饋!我修完之後,CICD 的機器看起來怪怪的,memcache 裝不起來,我晚點再重跑測試看看~

ddio commented 1 year ago

@toomore , memcahce 裝起來後,mypy 抱怨 main.py 有untyped function ,但這個 PR 都沒動到那塊 XD

想問你有建議怎處理嗎? https://github.com/COSCUP/COSCUP-Volunteer/actions/runs/4805751760/jobs/8553545806?pr=134

toomore commented 1 year ago

@ddio 我終於找到問題了,flask 2.3.1 的問題。現在亮綠燈了! https://github.com/COSCUP/COSCUP-Volunteer/pull/134/commits/84eea3511fe3bd5cbea35427ec21bcef463af231

ddio commented 1 year ago

@toomore 感恩!但要麻煩你 approve 呦,Github 不讓作者當 reviewer XD

toomore commented 1 year ago

順便紀錄一下,bug 跑到 pallets/werkzeug https://github.com/pallets/werkzeug/issues/2660