COSCUP / COSCUP-Volunteer

The COSCUP volunteer platform is an online tool that allows interested individuals to register as volunteers for the conference, and a way for volunteers to communicate with each other and with the organizers. COSCUP 志工平台是一個可以讓有興趣的人登錄成為 COSCUP 的志工，同時也提供志工彼此溝通和與大會聯繫的方式。

https://volunteer.coscup.org/

GNU Affero General Public License v3.0

67 stars 34 forks source link

Refactor the third party API in type hint #71

Closed toomore closed 2 years ago

toomore commented 2 years ago

修正為 type hint 與不複寫 requests.session funs.

Pull request type

Please check the type of change your PR introduces:

[x] Refactoring (no functional changes, no api changes)

What is the current behavior?

現在的寫法會造成 pylint 提示錯誤。

Issue Number: N/A

What is the new behavior?

type hint
fit pylint policy

Other information

N/A

pan93412 commented 2 years ago

43

pan93412 commented 2 years ago

[x] Refactoring (no functional changes, no api changes)

其實有 API changes，應該要算 breaking refactor。但考慮到這邊的大部分 methods 都沒有對外 public，所以只是提醒而已。