search

COSIMA / access-om2

Deprecated ACCESS-OM2 global ocean - sea ice coupled model code and configurations.
22 stars 23 forks source link

Change to yaml.safe_load for python tests #252

Closed aidanheerdegen closed 3 years ago

aidanheerdegen commented 3 years ago

Closes #251

aidanheerdegen commented 3 years ago

@aekiss Fixing the python in the testing I thought it would be worthwhile adding simple linting testing, otherwise it is difficult to know if the python is even correct because it is almost impossible to run easily.

This has the benefit of adding some CI to the repo, which an be built on for other static testing that might be useful.

If you are happy with this I will squash and merge.

aidanheerdegen commented 3 years ago

Actually, just noticed the travis stuff is not current, and the PEP8 link is 4 years old. I'll fix that and incorporate that test into the GH CI

aidanheerdegen commented 3 years ago

@aekiss I don't want to merge this without someone else just saying "yeah sure". It's not doing much, but I don't want to force this on your arbitrarily.

aidanheerdegen commented 3 years ago

Should have mentioned, I have fired off a repro-PR to make sure the python test stuff didn't break

https://accessdev.nci.org.au/jenkins/blue/organizations/jenkins/ACCESS-OM2%2Freproducibility_pull_request/detail/reproducibility_pull_request/13/pipeline

aekiss commented 3 years ago

I'm happy to say "yeah sure" - it sounds sensible, and although I don't have much understanding of the details, I trust your judgement :-)