Closed rmholmes closed 3 years ago
I think it might be a good idea to use some predefined constants (from ice_constants.F90, say) rather than the magic numbers.
100.0 => c11 273.51 => Tfresh
and define
d622 = rdgas/rvgas d378 = 1.-d622
Also add a quick reference for the formula.
How's this?
I'll test it again before it should be merged.
Looks good. Happy to merge if your tests look ok.
Ok the tests check-out, giving an identical figure to that shown at https://github.com/COSIMA/cice5/issues/57#issuecomment-827257955
I think it can be merged.
This approach uses a simpler formula for converting RH to QH than used by the model internals. This should not be an issue provided the same formula is used for the pre-processing when the JRA55-do provided QH is converted to RH.