search

COSIMA / cice5

Clone of The Los Alamos sea ice model (CICE) with ACCESS drivers. See https://github.com/CICE-Consortium/CICE-svn-trunk/tree/cice-5.1.2
4 stars 13 forks source link

Support non-BGC configs #65

Closed aekiss closed 1 year ago

aekiss commented 1 year ago

I should have thought a bit harder before merging in @hakaseh's support for coupled BGC https://github.com/COSIMA/cice5/commit/10b35272d33de78d2fece90c1513366c516244a1

CICE now expects to find surface nitrate and algae in the coupling fields, so it won't work with our usual physics-only configurations.

I guess this could be fixed with lots of #ifdefs, but that will give us 2 exes for each resolution. Is there a more elegant way to do it?

aekiss commented 1 year ago

Physics-only ACCESS-OM2 runs ok from a cold start if supplied with o2i.nc containing ssn_i and ssalg_i, e.g. using

      input:
            - /g/data/ik11/inputs/access-om2/input_bgc_20220224/cice_1deg
            - /g/data/ik11/inputs/access-om2/input_20201102/cice_1deg

in the ice section of config.yaml at 1 deg. But the next run fails because ssn_i and ssalg_i are missing from the restart if a non-BGC MOM5 exe is used.

So it should work to put https://github.com/COSIMA/cice5/blob/10b35272d33de78d2fece90c1513366c516244a1/drivers/auscom/cpl_forcing_handler.F90#L190-L191 in an if statement so they're only executed when doing coupled BGC (not sure what to use as the boolean test though). Probably wise to initialise ssn and ssalg to zero beforehand.

aekiss commented 1 year ago

https://github.com/COSIMA/cice5/commit/27bcc454cf292710c996c10e87218ec1e4c4bb7e This seems to work, though I suspect ssn and ssalg are uninitialised so that makes me nervous

aekiss commented 1 year ago

@russfiedler I'm wondering if you can advise - is it necessary to initialise ssn and ssalg if skl_bgc = .false.?

aekiss commented 1 year ago

Oh never mind, they're initialised on allocation: https://github.com/COSIMA/cice5/blob/master/drivers/auscom/cpl_interface.F90#L295-L296