search

COSIMA / cice5

Clone of The Los Alamos sea ice model (CICE) with ACCESS drivers. See https://github.com/CICE-Consortium/CICE-svn-trunk/tree/cice-5.1.2
4 stars 12 forks source link

Incorrect halo update for calving flux #68

Open aekiss opened 1 year ago

aekiss commented 1 year ago

There's a bug here:

https://github.com/COSIMA/cice5/blob/edcfa6f9c76ed05b63196ce4b5355fa5a8f4fe3a/drivers/auscom/cpl_interface.F90#L710

Calving flux is a scalar, so this should be 

  call ice_HaloUpdate(calv0, halo_info, field_loc_center, field_type_scalar)
aekiss commented 1 year ago

This hasn't affected any production runs to date, because we add the solid runoff into the liquid runoff and don't use the solid runoff: https://github.com/COSIMA/access-om2/issues/155#issuecomment-624911235

aekiss commented 1 year ago

It also doesn't explain the tripole seam bug https://github.com/COSIMA/access-om2/issues/86 as this halo bug was introduced years later in commit https://github.com/COSIMA/cice5/commit/3bbef261805b2a9844d165473b96f79b8668f437