rbeucher commented 1 year ago

Hi,

I have just fixed a small issue with python 3.10. Note that it is unclear to me whether the default value for the dropdown selector should be None or an empty string " ". Anyway I have just done the minimum change so that nothing breaks.

I have also changed tmpdir to tmp_path in the tests. The tmpdir fixture relies on the legacy py.path.local that is not really used anymore. tmp_path uses the standard pathlib.Path objects.

I have updated the CI to test for python 3.8, 3.9, 3.10 Note that I have dropped python 3.7 as it is not supported anymore by xarray since last january. python 3.7 is rather old now and has all sorts of issues so I would advice against maintaining compatibility for it... Versions 3.8, 3.9 and 3.10 are now on Gadi.

We (ACCESS-NRI MED) are working on improving the performance on Gadi. @echus @AndyHoggANU

Romain

codecov-commenter commented 1 year ago

Codecov Report

Merging #308 (f7c28a8) into master (915311f) will increase coverage by 0.01%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   54.97%   54.99%   +0.01%     
==========================================
  Files          22       22              
  Lines        1808     1811       +3     
==========================================
+ Hits          994      996       +2     
- Misses        814      815       +1

Impacted Files	Coverage Δ
cosima_cookbook/explore.py	`86.53% <66.66%> (-0.17%)`	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

micaeljtoliveira commented 1 year ago

LGTM!

@angus-g Would you like to have a look at this?

COSIMA / cosima-cookbook

Python 3.10 compatibility / Test suite tweaks #308

Codecov Report