COSIMA / cosima-cookbook

Framework for indexing and querying ocean-sea ice model output.
https://cosima-recipes.readthedocs.io/en/latest/
Apache License 2.0
57 stars 27 forks source link

Database module captures all warnings #337

Open navidcy opened 2 months ago

navidcy commented 2 months ago

I'm thinking of this line

https://github.com/COSIMA/cosima-cookbook/blob/a9f5fc9b2ff3daf1cca0b9dcd7173636c2e274e4/cosima_cookbook/database.py#L45

and the discussion over at https://github.com/COSIMA/cosima-recipes/issues/327#issuecomment-2051129125 regarding how an example was silently giving different results and we were missing all the xarray's warnings.

cc @dougiesquire, @angus-g

(spotted by @dsroberts)

aekiss commented 2 months ago

@angus-g that line was added to handle issue https://github.com/COSIMA/cosima-cookbook/issues/166, but should we re-enable warnings after searching for files is completed?

angus-g commented 2 months ago

Yeah, I think the warnings-off section should definitely be limited!