search

COSIMA / cosima-recipes

A cookbook of recipes (i.e., examples) for analysing ocean and sea ice model output
https://cosima-recipes.readthedocs.io
Apache License 2.0
46 stars 66 forks source link

Update `Spatial_selection.ipynb` notebook #272

Closed navidcy closed 1 year ago

navidcy commented 1 year ago

At the moment this notebook does not run. We need to update it and then add it to the list of automated tests in https://github.com/COSIMA/cosima-recipes/blob/main/test/test_notebooks.py

If we can make it work with MOM6 output it'd be even better!

navidcy commented 1 year ago

Also good idea is to deal with #267 while updating the notebook

lidefi87 commented 1 year ago

I have some code that creates a mask based on a polygon that we can then use to extract data. This would be useful if the study of interest has a boundary that is more complex than a rectangle/square. Do you think this could be added here or it would be better in a new notebook?

navidcy commented 1 year ago

If it's 1-2 cells then definitely add to this notebook. Is it much longer than that?

Also as discussed in #246 we should put this notebook under "Tutorials".

@lidefi87 are you joining tomorrow's hackathon? wanna undertake this task?

lidefi87 commented 1 year ago

I think it'll be more than 2 code chunks. Maybe I can make a new example under Tutorials in that case.

I was thinking of joining for about an hour when I go for lunch, which is often later than usual lunch time.