search

COSIMA / cosima-recipes

A cookbook of recipes (i.e., examples) for analysing ocean and sea ice model output
https://cosima-recipes.readthedocs.io
Apache License 2.0
46 stars 66 forks source link

Update `TemperatureSalinityDiagrams.ipynb` notebook #273

Closed navidcy closed 1 year ago

navidcy commented 1 year ago

At the moment this notebook does not run. We need to update it and then add it to the list of automated tests in https://github.com/COSIMA/cosima-recipes/blob/main/test/test_notebooks.py

If we can make it work with MOM6 output it'd be even better!

navidcy commented 1 year ago

Also good idea is to deal with #267 while updating the notebook

claireyung commented 1 year ago

Suggest to remove this notebook (https://github.com/COSIMA/cosima-recipes/blob/main/DocumentedExamples/TemperatureSalinityDiagrams.ipynb) as newer TS diagram notebook https://github.com/COSIMA/cosima-recipes/blob/main/DocumentedExamples/TemperatureSalinityDiagrams_mom5_mom6.ipynb is nicer :)

navidcy commented 1 year ago

Great! I like the suggestion. Less is more.