search

COSIMA / cosima-recipes

A cookbook of recipes (i.e., examples) for analysing ocean and sea ice model output
https://cosima-recipes.readthedocs.io
Apache License 2.0
44 stars 66 forks source link

Intake conversion Cross-contour_transport #356

Open rbeucher opened 3 months ago

rbeucher commented 3 months ago

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

navidcy commented 2 months ago

@taimoorsohail just checking: the Along_isobath_average.ipynb was pushed in this branch on purpose or was is supposed to go in #416 only?

taimoorsohail commented 2 months ago

I thought I pushed from taimoorsohail:main to Cosima-recipes:main? Either way, no, I wasn't trying to push in this branch. I was reviewing this PR request but there are significant bugs in the Cross-contour_transport code (not related to this PR - they are well documented in other issues), so I think @adele-morrison is ironing out those bugs.

navidcy commented 2 months ago

Your local clone must have had some edits from previous things you'd be working on and then you did something like git add * or git commit -am"message", either of which adds all the modifications to the commit.

That's a guess. I'll sort it out -- don't worry! :)

navidcy commented 2 months ago

I thought I pushed from taimoorsohail:main to cosima-recipes:main

I don't understand exactly what do you mean. Nobody is allowed to push to cosima-recipes:main, you can only make a PR to request merging changes to cosima-recipes:main.

This PR was opened from a branch of cosima-recipes. So to add commits to that PR you need to clone the main cosima-recipes branch, do git checkout INTAKE_Cross-contour_transport and then push commits to that branch.

Anyway I fixed it... I'm just trying to make it easier for other times but I'm not sure if I'm explaining myself properly. [I do admit that it's early am, I'm jet lagged and coffee shops are closed where I currently am! :)]

marc-white commented 2 weeks ago

I got about halfway through merging the updates from the trunk (PR #423) yesterday, but now can't continue without Gadi access. Whilst doing that, I identified a potential issue with the Intake catalogue of the dataset being used: https://github.com/ACCESS-NRI/access-nri-intake-catalog/issues/192

marc-white commented 2 weeks ago

I've completed merging the latest main into this branch, and completed the intake conversion at the same time (I think). As part of that, I've added a small section on chunking the data; for the data volume in use, I doubt it makes a lot of difference, but I think it's a useful example. @navidcy I'll add you as a reviewer; please let me know if there's anyone else I should add.

navidcy commented 2 weeks ago

Actually could you request review from somebody else? There are many COSIMAers who would be willing to contribute.