COSIMA / cosima-recipes

A cookbook 📒 of recipes (i.e., examples) for analysing ocean and sea ice model output. 👩🏽‍🍳🌊👨🏻‍🍳
https://cosima-recipes.readthedocs.io
Apache License 2.0
46 stars 66 forks source link

Intake conversion SeaIce_Plot_Example #369

Open rbeucher opened 5 months ago

rbeucher commented 5 months ago

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

anton-seaice commented 5 months ago

Thanks @rbeucher . It looks like this was based on an older version of this recipe, not including the updates (#294) from the hackathon last September.

Do you have someone to merge with the latest version of the recipe? Or shall I do that?

rbeucher commented 5 months ago

Feel free to do it. I took a cautious approach and decided not to merge changes from main

anton-seaice commented 5 months ago

This PR is blocked on _OM4_025.JRARYF not being in the Intake Catalog

@adele-morrison : Is this experiment appropriate to add to the catalog? The criteria are loosely:

adele-morrison commented 5 months ago

Yes, sure let's include OM4_025.JRA_RYF in the Intake Catalog. Sounds like it's at least worth keeping for the next year for OM3 development comparison.