COSIMA / cosima-recipes

Example recipes for analyzing model output using the cosima-cookbook infrastructure
https://cosima-recipes.readthedocs.io
Apache License 2.0
43 stars 65 forks source link

Intake conversion Transport_Through_Straits #372

Closed rbeucher closed 16 hours ago

rbeucher commented 3 weeks ago

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thomas-Moore-Creative commented 2 days ago

Have reviewed and made the following changes for further review by @anton-seaice.

These changes include:

The updated code runs as the original code did, including this erroneous result for Lombok Strait. CleanShot 2024-07-01 at 16 57 05@2x

navidcy commented 16 hours ago

nice job!