search

COSIMA / cosima-recipes

Example recipes for analyzing model output using the cosima-cookbook infrastructure
https://cosima-recipes.readthedocs.io
Apache License 2.0
43 stars 65 forks source link

Intake conversion Spatial_selection #379

Open rbeucher opened 3 weeks ago

rbeucher commented 3 weeks ago

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 2 weeks ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-06-17T00:56:42Z ----------------------------------------------------------------

@aidanheerdegen - Is it correct to refer to the 1D coordinates as 'latitude/longitude' as they are not true latitude and longitudes? Shouldn't they just be X/Y (or possibly 'grid_latitude/grid_longitude' ?


navidcy commented 2 weeks ago

hmmmm.... not X, Y... right?

anton-seaice commented 2 weeks ago

I made some changes so this runs, happy for someone to review now and leave the question about 1D coordinate names for later!

review-notebook-app[bot] commented 1 week ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-06-24T06:19:26Z ----------------------------------------------------------------

Line #1.    cat_subset = catalog[expt]

Is "datastore" a more correct name than "cat_subset" ?


navidcy commented 1 week ago

cat_subset means nothing to me... so yes, anything bit more verbose and self-explanatory is better!

aidanheerdegen commented 1 week ago

@aidanheerdegen - Is it correct to refer to the 1D coordinates as 'latitude/longitude' as they are not true latitude and longitudes? Shouldn't they just be X/Y (or possibly 'grid_latitude/grid_longitude' ?

They are true latitude and longitudes, just not correct for the data in the file.

I think GFDL might use "nominal latitude/longitude"? I think X/Y is misleading, and they are lons/lats.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.