search

COSIMA / cosima-recipes

A cookbook of recipes (i.e., examples) for analysing ocean and sea ice model output
https://cosima-recipes.readthedocs.io
Apache License 2.0
44 stars 66 forks source link

Intake conversion Using_Explorer_tools #382

Closed rbeucher closed 3 months ago

rbeucher commented 3 months ago

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

anton-seaice commented 3 months ago

This change doesn't make sense.

The notebook Using_Explorer_tools is about using the explorer in the cosima cookbook, there is no equivalent for the Intake Catalogue at this point.

I suggest we leave this recipe unchanged, at some point we might make a new notebook to explore using the Intake Catalogue.

(Maybe we should add a note encouraging people to use the Intake Catalogue, and saying this recipes is for historical reasons only)

rbeucher commented 3 months ago

Sure. I have just created a bunch of PR based on @max-anu work. I did not go through all the changes and understand that some PRs might be irrelevant.

anton-seaice commented 3 months ago

Closing as no-change for now, we'll keep this notebook for reference for cookbook users.