Add a simple version of model-derived mixed-layer depth plot

COSIMA / cosima-recipes

A cookbook of recipes (i.e., examples) for analysing ocean and sea ice model output

https://cosima-recipes.readthedocs.io

Apache License 2.0

46 stars 66 forks source link

Add a simple version of model-derived mixed-layer depth plot #400

Open ribeiron opened 4 months ago

ribeiron commented 4 months ago

Mixed layer depth in the Southern Ocean

This script loads model-derived MLD data and plots the Mixed Layer Depth (MLD) for different sectors of the Southern Ocean using the IAF cycle 3 output from ACCESS-OM2-01 (I only plot East Antarctica, but a list is created to enable the plots for other regions.

This script is a simplified version of this code https://github.com/lidefi87/ACCESS_scripts_DFA/blob/main/Scripts/Stephy/MLD_calc_Denisse.ipynb made by Denisse Fierro Arcos that was posted as a issue on ACCESS-hive.

I am still to calculate MLD from the models potential density and create a comparison.
I would also like to plot winter and summer MLD separately.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

navidcy commented 4 months ago

Hi @ribeiron! Nice!

Just few comments: I see that you read some input from /g/data/v45/ns3783; could we avoid that? It'd be nice to just load some data via the cookbook and do all the calculations from there.

Ping us when this is ready to review? I see that it's not quite ready there so I will convert this to draft for now. How does that sound?

ribeiron commented 4 months ago

Hi @navidcy,

That is all good. I probably won't have time to work on this straight away, but I plan to revisit it. Can you just explain one thing to me: when you convert a pull request to a draft, do I have to do anything differently? Or just creating a new pull request for the same code/file will reopen it or add it to this same pull request thread?

Thank you!

navidcy commented 4 months ago

Oh no. Nothing different needed from your side. You can treat the draft PR as a "normal" PR. "Draft" is only a label on the PR just to inform other people know that this PR is still work in progress so that they don't start reviewing it... There is a button towards the bottom of the PR that says "Ready to review" which converts a Draft PR back to a normal PR.

So whenever you want to continue working just do more commits on that branch you were and push. They will automatically incorporated in this PR you opened.

navidcy commented 4 months ago

That's the only difference; just a label

ribeiron commented 4 months ago

Perfect. Thanks for clarifying. I'll ping you when I am done, but it might take me a bit.