search

COSIMA / cosima-recipes

A cookbook 📒 of recipes (i.e., examples) for analysing ocean and sea ice model output. 👩🏽‍🍳🌊👨🏻‍🍳
https://cosima-recipes.readthedocs.io
Apache License 2.0
46 stars 66 forks source link

Convert first person singular to first person plural in a recipe #457

Closed navidcy closed 2 months ago

navidcy commented 2 months ago

The recipe had sprinkled "I choose to do this", "I plot that" and I was confused. First of all I didn't know who "I" was but also it felt a bit alienating. I converted to "we...".

Also there was a claim that some cells would take 20min; it took 1 min for me. I removed the claim. The timing on the cells is self explanatory. There was another commented text and a claim that "I tested this recipe using these other examples" but since we can't ensure that is true as time moves on I rephrased it to something a bit less concrete.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

navidcy commented 2 months ago

I find that most people don't review or respond to my review requests so I tend to assign always PRs to @julia-neme and @adele-morrison. Sorry for that @julia-neme and @adele-morrison, but also THANKS!