Add sector-based sea ice analysis (#393)

[serenaschroeter]

Code to calculate and visualise sector-based sea ice metrics for Southern Hemisphere based on sector definitions in Raphael & Hobbs, 2014. Obtains NSIDC observational estimate directly from PolarWatch, and uses COSIMA Cookbook to access model data.

Closes #393

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[navidcy]

I updated the branch with changes that happened in main. You should pull the changes before you continue edit the notebook otherwise merge conflicts might created.

[marc-white]

Just noting that the experiment data referenced in this notebook appears to be available via access-nri-intake-catalog. That being said, it's probably best to bring the notebook in 'as is' (modulo any other changes), and convert it to intake later under #313 .

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:23Z ----------------------------------------------------------------

We call them "recipes", not "scripts". Could you please rephrase? Also, define SIA in the text as well, at least the first time.

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Could you add a link to the reference? E.g., [Raphael & Hobbs (2014)](https://doi.org/XXXX.YYYY)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Why we have numbers 71.? Either 71.0 if we need that or just 71?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:25Z ----------------------------------------------------------------

put this cell at the top

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Could you add a link to the reference? E.g., [Raphael & Hobbs (2014)](https://doi.org/XXXX.YYYY)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Why we have numbers 71.? Either 71.0 if we need that or just 71?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:25Z ----------------------------------------------------------------

put this cell at the top

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:24Z ----------------------------------------------------------------

Why we have numbers 71.? Either 71.0 if we need that or just 71?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:25Z ----------------------------------------------------------------

put this cell at the top

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:25Z ----------------------------------------------------------------

put this cell at the top

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:26Z ----------------------------------------------------------------

Let's make a different step for the conversion, e.g.,

OM2_SIC = OM2_SIC.fillna(0)

OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2

(Also, not 1.e-6 since what does . add here?)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #6.    CDR_area = CDR_area / 1000

I don't understand why divide by 1000 here

_anton-seaice commented on 2024-09-18T06:46:53Z_ ----------------------------------------------------------------

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

_navidcy commented on 2024-10-04T04:44:53Z_ ----------------------------------------------------------------

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2024-09-17T03:29:27Z ----------------------------------------------------------------

Line #23.    OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values])

here, as well as previous line add space after commas?

anton-seaice commented 2 months ago

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[anton-seaice]

It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago

---

View entire conversation on ReviewNB

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

navidcy commented on 2024-10-04T04:45:14Z ----------------------------------------------------------------

What is a "glow up"?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

I think we should mention here atleast that the obs start in 1979 ?

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:58Z ----------------------------------------------------------------

Line #2.    client=Client(threads_per_worker=1)

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:59Z ----------------------------------------------------------------

tarea is just the cell area

review-notebook-app[bot] commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:56:00Z ----------------------------------------------------------------

Line #8.    CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True)

you can normally just slice(start_year,end_year) and the meaning is the same

navidcy commented 2 months ago

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

navidcy commented 1 month ago

@serenaschroeter are you happy with dealing with the comments above? would you like help?

navidcy commented 1 month ago

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

navidcy commented 1 month ago

What is a "glow up"?

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[navidcy]

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-09-18T06:55:57Z ----------------------------------------------------------------

We've had a glow up of recipe names / titles recently, we've got a

Sea_Ice_Area_Concentration_Volume_with_Obs.ipynb

So I think this recipe could be

Sea_Ice_Sector_Areas_with_Obs ??

What's a "glow up"?

I suggest _Observations instead of _Obs.

[navidcy]

@serenaschroeter are you happy with dealing with the comments above? would you like help?

[navidcy]

So is this a unit conversion from m^2 -> km^2...? no...

Let's add a comment that explains?

Or, if the pss25area_v3.dat has the data with some arbirtrariness of whoever made it, let's remake the .dat file to make sense?

---

View entire conversation on ReviewNB

[navidcy]

What is a "glow up"?

---

View entire conversation on ReviewNB