Fix formatting of cice grid file

anton-seaice commented 7 months ago

This PR fixes two issues:

In CICE6, angle of t-cell is called anglet however in the cice5-auscom build, we called this angleT.
To make it easier to combine this file with cice history output, use names ni, nj for x and y dimensions. In conjunction with https://github.com/COSIMA/MOM6-CICE6/pull/54, this should allow a straight / no-warnings xr.merge of the grid with history output. Thanks to @aidanheerdegen for the suggestion.

Closes #16

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@f5d137f). Click here to learn what that means.

:exclamation: Current head 569849e differs from pull request most recent head 5a71eae. Consider uploading reports for the commit 5a71eae to get more accurate results

Files	Patch %	Lines
esmgrids/cice_grid.py	8.33%	11 Missing :warning:
esmgrids/cli.py	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #18 +/- ## ====================================== Coverage ? 3.38% ====================================== Files ? 20 Lines ? 1241 Branches ? 0 ====================================== Hits ? 42 Misses ? 1199 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anton-seaice commented 7 months ago

@dougiesquire apologies for the many reviews. please look at #17 first.

COSIMA / esmgrids

Fix formatting of cice grid file #18

Codecov Report