COSIMA / libaccessom2

ACCESS-OM2 library
3 stars 7 forks source link

simple_timers have a bug: optional arguments in init() are the wrong way around #11

Closed nichannah closed 5 years ago

nichannah commented 5 years ago

OK, I think there is a confluence of bugs … simple_timers_enabled() is returning .false. but it is being used to control include_first_call. And the timers are working overall because that’s the default that would explain everything you are seeing

marshall [3:50 PM] lmao.... also explains the low numbers youre getting too i suppose https://arccss.slack.com/archives/C9Q7Y1400/p1544157553168800 nic { timer-ice_step min: 2.021 } { timer-ice_step max: 48.916 } { timer-ice_step mean: 2.212 } { timer-ice_step variance: 7.627 } Posted in #om2devToday at 3:39 PM i mean high number.. i guess thats the anomalous one

nic [3:51 PM] yeah OK, great. thanks for finding all those bugs! I’m gonna fix things up I think I’ll just swap the last two arguments of the init()

marshall [3:52 PM] yes, i can confirm that explicitly setting enabled with the value as the others removed my timer!