search

COSIMA / libaccessom2

ACCESS-OM2 library
3 stars 7 forks source link

Replaced non-standard inquire by refactoring #52

Closed aidanheerdegen closed 4 years ago

aidanheerdegen commented 4 years ago

Closes #48

aidanheerdegen commented 4 years ago

Happy to merge this @aekiss?

Not sure why the CI isn't showing automatically, but this does pass the compilation test

https://travis-ci.org/github/COSIMA/libaccessom2/builds/696291045

aidanheerdegen commented 4 years ago

I blame python and it's ask for forgiveness rather than permission approach. Arguably this is better code, as it will also pick up issues with writing to the RESTART directory.

As @russfiedler has reviewed and given the thumbs up, and the automated jenkins testing is still borked, will merge. Can you then give it a burl to check it fixes the bug I introduced @aekiss?

aekiss commented 4 years ago

thanks @aidanheerdegen, this is working

aidanheerdegen commented 4 years ago

Thanks @aekiss. The least I could do seeing as I broke it. I'll push a new tag to trigger a release, which is how access-om2 uses libaccessom2.