search

COSIMA / regional-mom6

Automatic generation of regional configurations of the Modular Ocean Model 6 (MOM6) in Python
https://regional-mom6.readthedocs.io/en/latest
MIT License
24 stars 13 forks source link

`setup_run_directory` includes arguments that are either boolean or strings #134

Closed navidcy closed 7 months ago

navidcy commented 7 months ago

The setup_run_directory method

https://github.com/COSIMA/regional-mom6/blob/c2c6dda9077a3f8209118a562df1f1421870fa1d/regional_mom6/regional_mom6.py#L1438

uses surface_forcing argument that seems to take either False or a string, e.g., "era5".

This is prone for mistakes though since, at least myself, when I see a variable that can be False I assume it's a boolean so True or False are the only allowed values.

_Originally posted by @navidcy in https://github.com/COSIMA/regional-mom6/pull/95#discussion_r1542377022_

navidcy commented 7 months ago

This was closed by #135