search

COSIMA / regional-mom6

Automatic generation of regional configurations of the Modular Ocean Model 6 (MOM6) in Python
https://regional-mom6.readthedocs.io/en/latest
MIT License
22 stars 11 forks source link

Issues with ERA5 specific humidity and surface pressure computation #171

Open navidcy opened 5 months ago

navidcy commented 5 months ago

At https://regional-mom6.readthedocs.io/en/latest/demo_notebooks/reanalysis-forced.html#Step-7:-Set-up-ERA5-forcing: there are some issues:

  1. You should also say you are using the Antoine equation for vapour pressure as a function of temperature.

  2. q = 0.622 * RH * P_sat / P = 0.622 * P_vap / P

  3. Where does the 0.001 come from?

  4. The T in the first equation should really be T_d.

found by @CallumJShakespeare

navidcy commented 5 months ago

We need to clear up this code here

https://github.com/COSIMA/regional-mom6/blob/305f169e2db1e476e20b2f5c002791c6c97be797/regional_mom6/regional_mom6.py#L1612-L1619

It might be cleaner if we convert this into a function. But definitely we should avoid hardcoding numbers in, but rather define variables with values so that it's obvious what's happening here.