COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 58 forks source link

Have supernova kick magnitude and angles be optionally input to kick.f #110

Closed astroJeff closed 5 years ago

astroJeff commented 5 years ago

For integrating cosmic with dart_board, there needs to be an option to pass along the SN natal kick and angles (and a second set for the second SN in double compact object binaries) from the external python call to the bse fortran executable. This would be instead of generating the kick randomly within kick.f.

scottcoughlin2014 commented 5 years ago

I have a possibly outrageous proposal for this.

Mike Kyle and I will have a PR request soon that returns the natal kicks (vk in the Fortran) and the parameter you want to pass directly into kick.f the system velocities and the total systemic velocity (if it survives both SN) as well as the changes in the angle of the orbital angular momentum caused be both supernova (and possible if we can figure it out the total change in the orbital angular momentum is the binary survives both SN).

In the bkick array these values will be in the following indices

13,14 natal kicks 1,2 (after all relevant physics (i.e. not just selected from maxwellian but after fallback is applied)) 15,16,17 sys 1, sys2, systot 18,19,20 theta1, theta2, thetaTot.

so bkick is now a 20 point vector where we leave 0-12 to be the convoluted logic that was already in kick.f

It is possible to provide the logic that if you do not want the natal kicks to be generated by kick.f through selection from maxwellian and applying some scaling to the selected kick, you could simply feed in the bkick array where values 13,14 already have a nonzero value. and then kick.f skips the vk selection entirely.

Scotty

scottcoughlin2014 commented 5 years ago

Actually, I think feeding in

[vk1, phi1, theta1, vk2, phi2, theta2] is easier then my convulted plan. I think I can get that in with this upcoming PR

katiebreivik commented 5 years ago

This is treated in this PR: 109