search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 58 forks source link

Print issue when closing files #377

Closed michaelzevin closed 4 years ago

michaelzevin commented 4 years ago

Super minor but was bothering my OCD. When there is an error and the open files get closed, it doesn't use linebreaks and is hard to read. It also looks like it repeats the print statement for some reason. See the attached output file.

Rather than: ValueError: You have supplied an unknown method to filter out the bpp or bcm array. Known methods are ['binary_state'] Closing remaining open files:dat_kstar1_13_14_kstar2_13_14_SFstart_13700.0_SFduration_0.0_metallicity_0.01.h5...donedat_kstar1_13_14_kstar2_13_14_SFstart_13700.0_SFduration_0.0_metallicity_0.01.h5...done

It would be cleaner as: ValueError: You have supplied an unknown method to filter out the bpp or bcm array. Known methods are ['binary_state'] Closing remaining open files: dat_kstar1_13_14_kstar2_13_14_SFstart_13700.0_SFduration_0.0_metallicity_0.01.h5...done

output.txt

katiebreivik commented 4 years ago

take it up with h5py.

michaelzevin commented 4 years ago

Can't fix, this is h5's problem