COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

Generic powerlaw try 2 #453

Closed scottcoughlin2014 closed 3 years ago

katiebreivik commented 3 years ago

@scottcoughlin2014 -- I have verified that this works for everything except if the alpha is set to 1.0. This is the same problem I think we ran into before where a divide by zero happens since the dividend from the last line of utils.rndm is: 1 + g = 0.0 where from the updated code g = -1 * alpha = -1.

Maybe the best option here is to just catch the special case for alpha=1.0 and not use rndm. Happy to hear other suggestions though!

codecov[bot] commented 3 years ago

Codecov Report

Merging #453 (e9e066e) into develop (1a732b9) will increase coverage by 36.07%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #453       +/-   ##
============================================
+ Coverage    50.73%   86.79%   +36.07%     
============================================
  Files           41       41               
  Lines         8236    25480    +17244     
============================================
+ Hits          4178    22115    +17937     
+ Misses        4058     3365      -693     
Impacted Files Coverage Δ
cosmic/sample/sampler/independent.py 63.36% <83.33%> (+6.93%) :arrow_up:
cosmic/src/corerd.f 0.00% <0.00%> (-33.33%) :arrow_down:
cosmic/sample/sampler/cmc.py 80.65% <0.00%> (-8.38%) :arrow_down:
cosmic/utils.py 81.17% <0.00%> (-1.24%) :arrow_down:
cosmic/src/ran3.f 100.00% <0.00%> (ø)
cosmic/src/benchmarkevolv2.f 100.00% <0.00%> (ø)
cosmic/sample/initialcmctable.py 95.38% <0.00%> (+0.15%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:
cosmic/sample/cmc/elson.py 86.96% <0.00%> (+0.23%) :arrow_up:
cosmic/src/zcnsts.f 98.87% <0.00%> (+1.89%) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a732b9...e9e066e. Read the comment docs.