search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

Changing qc check to encompass all MS stars re: #452 #456

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

fixing qcrit checks to treat all MS (kstar=0,1,7) w/ qc>qcrit the sam…e way. we talked about this in the cosmic call This fixes issue #452

codecov[bot] commented 3 years ago

Codecov Report

Merging #456 into develop will decrease coverage by 1.56%. The diff coverage is 3.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #456      +/-   ##
===========================================
- Coverage    32.10%   30.55%   -1.56%     
===========================================
  Files           38       39       +1     
  Lines         7610     7929     +319     
===========================================
- Hits          2443     2422      -21     
- Misses        5167     5507     +340
Impacted Files Coverage Δ
cosmic/MC_samp.py 0.00% <0.00%> (ø)
cosmic/Match.py 0.00% <0.00%> (ø)
cosmic/bse_utils/zcnsts.py 0.00% <0.00%> (ø)
cosmic/bse_utils/zdata.py 0.00% <0.00%> (ø)
cosmic/checkstate.py 0.00% <0.00%> (ø)
cosmic/evolve.py 0.00% <0.00%> (ø)
cosmic/filter.py 0.00% <0.00%> (ø)
cosmic/plotting.py 0.00% <0.00%> (ø)
cosmic/sample/__init__.py 0.00% <0.00%> (ø)
cosmic/sample/cmc/elson.py 0.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f01fe65...080e042. Read the comment docs.