search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

We lost timestep_conditions when we did the cmc integration #461

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

In #420 we added check_dtp as a common variable but I don't think it is set for the case where timestep_conditions are specified. I think that all we need to do is set check_dtp somewhere in the evolv2.f based on the checkstate_array.

katiebreivik commented 3 years ago

Found it!

https://github.com/COSMIC-PopSynth/COSMIC/blob/74ccbd70d7e1af1c14bde46bb83836bcfb6f2767/cosmic/checkstate.py#L74

https://github.com/COSMIC-PopSynth/COSMIC/blob/74ccbd70d7e1af1c14bde46bb83836bcfb6f2767/cosmic/checkstate.py#L87

In the above two places, we forgot to update the common block definitions to check_dtp instead of checkstate_array

scottcoughlin2014 commented 3 years ago

462 fixes this