Closed giacomofragione closed 3 years ago
Merging #476 (de6398e) into develop (898481f) will increase coverage by
18.02%
. The diff coverage is18.01%
.
@@ Coverage Diff @@
## develop #476 +/- ##
============================================
+ Coverage 30.43% 48.44% +18.02%
============================================
Files 39 40 +1
Lines 7960 8259 +299
============================================
+ Hits 2422 4001 +1579
+ Misses 5538 4258 -1280
Impacted Files | Coverage Δ | |
---|---|---|
cosmic/sample/cmc/king.py | 0.00% <0.00%> (ø) |
|
cosmic/sample/sampler/independent.py | 56.93% <44.83%> (+56.93%) |
:arrow_up: |
cosmic/sample/initialcmctable.py | 95.38% <93.75%> (+95.38%) |
:arrow_up: |
cosmic/sample/sampler/cmc.py | 99.22% <100.00%> (+99.22%) |
:arrow_up: |
cosmic/sample/sampler/multidim.py | 17.85% <0.00%> (+17.85%) |
:arrow_up: |
cosmic/filter.py | 29.69% <0.00%> (+29.69%) |
:arrow_up: |
cosmic/checkstate.py | 36.59% <0.00%> (+36.59%) |
:arrow_up: |
cosmic/Match.py | 52.56% <0.00%> (+52.56%) |
:arrow_up: |
... and 12 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c9cb649...3cde817. Read the comment docs.
Hey @giacomofragione and @carlrodriguez -- can y'all confirm that the last commit I have which I think resolved the conflicts introduced by merging in Carl's branch is correct. Once you are happy, either of you can merge this in!
Closing as I made a new PR with same commits but merged with upstream and added unit tests
Stars with mass > Msort can be sampled with a different binary fraction and strategy.