COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

sub-Eddington accretion in the docs and example Params.ini #478

Closed michaelzevin closed 3 years ago

michaelzevin commented 3 years ago

changed docs to reflect that eddfac flag can be less than 1, which allows for sub-Eddington accretion. The flag checks in utils.py already allow for any eddfac >= 0.

Let me know if I missed any docs!

codecov[bot] commented 3 years ago

Codecov Report

Merging #478 (18a71cf) into develop (898481f) will increase coverage by 18.30%. The diff coverage is 15.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #478       +/-   ##
============================================
+ Coverage    30.43%   48.73%   +18.30%     
============================================
  Files           39       40        +1     
  Lines         7960     8194      +234     
============================================
+ Hits          2422     3993     +1571     
+ Misses        5538     4201     -1337     
Impacted Files Coverage Δ
cosmic/sample/cmc/king.py 9.30% <9.30%> (ø)
cosmic/sample/sampler/cmc.py 96.97% <25.00%> (+96.97%) :arrow_up:
cosmic/sample/initialcmctable.py 95.38% <93.75%> (+95.38%) :arrow_up:
cosmic/sample/sampler/multidim.py 17.85% <0.00%> (+17.85%) :arrow_up:
cosmic/filter.py 29.69% <0.00%> (+29.69%) :arrow_up:
cosmic/checkstate.py 36.59% <0.00%> (+36.59%) :arrow_up:
cosmic/Match.py 52.56% <0.00%> (+52.56%) :arrow_up:
cosmic/evolve.py 55.88% <0.00%> (+55.88%) :arrow_up:
cosmic/sample/sampler/independent.py 62.14% <0.00%> (+62.14%) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b27105c...2cc021b. Read the comment docs.

katiebreivik commented 3 years ago

Not sure why we hadn't merged this in yet!