COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

cmc has mass-dependent pts1 values should cosmic also have this? #479

Open katiebreivik opened 3 years ago

katiebreivik commented 3 years ago

We know that the setting for pts1 has a strong impact on the total runtime of a binary based on tests that @astroJeff has done. This is a big enough deal in cmc, which is way more computationally expensive, that it is important to dynamically set pts1 for massive/not massive stars. Maybe we should consider a similar type of dynamical setting for cosmic to optimize?

scottcoughlin2014 commented 3 years ago
          /*If we've got a large MS star, we need to reduce the timestep, otherwise
           * we miss the transition from MS to HG to giant, and won't start applying
           * winds for massive stars at the right time*/
          if(star[k].zams_mass > 18){
              bse_set_pts1(BSE_PTS1/10.);
              reduced_timestep = 1;
          }
astroJeff commented 3 years ago

Relevant plots attached. cosmic_benchmarking_mass_pts1.pdf cosmic_benchmarking_pts1.pdf