found bug in utils for filtering bcm and bpp

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)

GNU General Public License v3.0

47 stars 59 forks source link

found bug in utils for filtering bcm and bpp #482

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

Jared Siegel pointed out that we are missing a significant amount of LMXBs because we are filtering on the final kstars in the bcm array but an LXMB won't necessarily have an LMXB final kstar at the end of it's evolution.

astroJeff commented 3 years ago

When Jared mentioned this issue he found, I was wondering what the problem was. Glad it's a simple fix.

scottcoughlin2014 commented 3 years ago

filtering needs total over haul