COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
47 stars 59 forks source link

rethinking convergence and filtering #493

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

Renamed filter_bpp_bcm to filter_bin_state, reordered filtering so that we don't lose intermediate evolutionary states (e.g. xrbs) with the bin_state filtering.

Now the process is: (-) get the converging data set and bin_nums for conv_limits (-) filter the converging data set on bin_state choice (-) filter bcm/bpp/initC/kick to only contain data within conv_limits if user specified request to filter them, otherwise, don't (-) compute convergence on conv dataframe with conv_limits

codecov[bot] commented 3 years ago

Codecov Report

Merging #493 (d9d75f6) into develop (898481f) will increase coverage by 18.69%. The diff coverage is 51.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #493       +/-   ##
============================================
+ Coverage    30.43%   49.11%   +18.69%     
============================================
  Files           39       41        +2     
  Lines         7960     8232      +272     
============================================
+ Hits          2422     4043     +1621     
+ Misses        5538     4189     -1349     
Impacted Files Coverage Δ
cosmic/MC_samp.py 98.31% <ø> (+98.31%) :arrow_up:
cosmic/Match.py 52.56% <ø> (+52.56%) :arrow_up:
cosmic/bse_utils/zcnsts.py 100.00% <ø> (+100.00%) :arrow_up:
cosmic/bse_utils/zdata.py 100.00% <ø> (+100.00%) :arrow_up:
cosmic/evolve.py 55.42% <0.00%> (+55.42%) :arrow_up:
cosmic/plotting.py 0.00% <ø> (ø)
cosmic/sample/initialbinarytable.py 94.44% <ø> (+94.44%) :arrow_up:
cosmic/sample/cmc/king.py 17.71% <17.71%> (ø)
cosmic/sample/sampler/multidim.py 17.57% <20.00%> (+17.57%) :arrow_up:
cosmic/src/evolv2.f 41.32% <23.08%> (-1.28%) :arrow_down:
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f17040e...d9d75f6. Read the comment docs.